|To:||Thomas Graf <tgraf@xxxxxxx>|
|Subject:||Re: [RFC] textsearch infrastructure + skb_find_text()|
|From:||Pablo Neira <pablo@xxxxxxxxxxx>|
|Date:||Thu, 05 May 2005 19:02:26 +0200|
|Cc:||netdev@xxxxxxxxxxx, jamal <hadi@xxxxxxxxxx>|
|User-agent:||Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.5) Gecko/20050105 Debian/1.7.5-1|
Thomas Graf wrote:
The patch is separated into 3 parts, the first one being the textsearch infrastructure itself followed by a simple Knuth-Morris-Pratt implementation for reference. I'm also working on what could be called the smallest regular expression implementation ever but I left that out for now since it still has issues. Last but not least the function skb_find_text() written in a hurry and probably not yet correct but you should get the idea. From a userspace perspective the first user will be an ematch but writing it will be peanuts so I left it out for now.
I haven't got too much time to review this stuff in deep though. Impressive work, but I still miss something, some comments:
- A custom destroy function in ts_ops.
- I don't see a way to look for matches in fragments. I mean, say we've got "dancing " in a fragment and "chicken" in the next one. Currently we don't get a match.
- I particularly like Rusty's skb iterator, well you've refactored that code anyway.
I've been reworking the framework for string matching that I sent you two/three months ago, you've definitely worked on a good base. Since then I've introduced a lot of changes and actually I've been testing it (ick, that means that we've clashed!).
I think that I can merge both works and then roll on. I still need more time to study more in deep your proposition.
|<Prev in Thread]||Current Thread||[Next in Thread>|
|Previous by Date:||e1000 (?) jumbo frames performance issue, Michael Iatrou|
|Next by Date:||Re: Mystery packet killing tg3, Peter Buckingham|
|Previous by Thread:||Re: [RFC] textsearch infrastructure + skb_find_text(), Thomas Graf|
|Next by Thread:||Re: [RFC] textsearch infrastructure + skb_find_text(), Thomas Graf|
|Indexes:||[Date] [Thread] [Top] [All Lists]|