| To: | acme@xxxxxxxxxxxxxxxxxx |
|---|---|
| Subject: | [PATCH 0/4] resource release cleanup in net/ (take 2) |
| From: | Jesper Juhl <juhl-lkml@xxxxxx> |
| Date: | Sun, 1 May 2005 03:46:10 +0200 (CEST) |
| Cc: | Arnaldo Carvalho de Melo <arnaldo.melo@xxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, Jouni Malinen <jkmaline@xxxxxxxxx>, James Morris <jmorris@xxxxxxxxxxxxxxxx>, Pedro Roque <roque@xxxxxxxxxxx>, Alexey Kuznetsov <kuznet@xxxxxxxxxxxxx>, Kunihiro Ishiguro <kunihiro@xxxxxxxxxxxxxx>, Mitsuru KANDA <mk@xxxxxxxxxxxxxx>, lksctp-developers@xxxxxxxxxxxxxxxxxxxxx, Andy Adamson <andros@xxxxxxxxx>, Bruce Fields <bfields@xxxxxxxxx>, netdev@xxxxxxxxxxx, linux-net@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, juhl-lkml@xxxxxx |
| In-reply-to: | <39e6f6c705043014264eb4c0c5@xxxxxxxxxxxxxx> |
| References: | <Pine.LNX.4.62.0504302219520.2094@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <39e6f6c705043014264eb4c0c5@xxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Sat, 30 Apr 2005, Arnaldo Carvalho de Melo wrote:
> On 4/30/05, Jesper Juhl <juhl-lkml@xxxxxx> wrote:
> > Hi David,
> >
> > Since Andrew merged the patch that makes calling crypto_free_tfm() with a
> > NULL pointer safe into 2.6.12-rc3-mm1, I made a patch to remove checks for
> > NULL before calling that function, and while I was at it I removed similar
> > redundant checks before calls to kfree() and vfree() in the same files.
> > There are also a few tiny whitespace cleanups in there.
>
> Jesper, I'd suggest that you left whitespaces for a separate patch, it
> is always,
> IMHO, better to have as small a patch as possible for reviewing.
>
Sure thing. I've split the patches, and I believe that me going through
them a second time did them good, there are a few tiny changes over the
first version.
I split the patch in 4 parts (will send as replies to this mail) :
1) crypto_free_tfm related changes
2) kfree related changes
3) vfree related changes
4) whitespace changes
The whitespace changes ended up fairly bigger than initially. I expanded
the cleanup a bit. It's not a perfect, 100% complete cleanup, but it's IMO
a lot better than the originals.
--
Jesper
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: patch: Action repeat, Patrick McHardy |
|---|---|
| Next by Date: | [PATCH 1/4] resource release cleanup in net/ (take 2), Jesper Juhl |
| Previous by Thread: | Re: [PATCH] resource release cleanup in net/, Arnaldo Carvalho de Melo |
| Next by Thread: | [PATCH 1/4] resource release cleanup in net/ (take 2), Jesper Juhl |
| Indexes: | [Date] [Thread] [Top] [All Lists] |