netdev
[Top] [All Lists]

Re: patch2: del/get byid

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: patch2: del/get byid
From: jamal <hadi@xxxxxxxxxx>
Date: Fri, 29 Apr 2005 20:01:21 -0400
Cc: Alexey Kuznetsov <kuznet@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx, "David S. Miller" <davem@xxxxxxxxxxxxx>
In-reply-to: <20050429234952.GB22699@xxxxxxxxxxxxxxxxxxx>
Organization: unknown
References: <20050428022549.GA23556@xxxxxxxxxxxxxxxxxxx> <1114655980.7663.76.camel@xxxxxxxxxxxxxxxxxxxxx> <20050428024253.GA23695@xxxxxxxxxxxxxxxxxxx> <1114656932.7663.88.camel@xxxxxxxxxxxxxxxxxxxxx> <20050428030325.GB23823@xxxxxxxxxxxxxxxxxxx> <1114658657.7663.110.camel@xxxxxxxxxxxxxxxxxxxxx> <1114698033.7663.197.camel@xxxxxxxxxxxxxxxxxxxxx> <20050428231154.GA14215@xxxxxxxxxxxxxxxxxxx> <1114779104.7800.22.camel@xxxxxxxxxxxxxxxxxxxxx> <1114816846.8929.6.camel@xxxxxxxxxxxxxxxxxxxxx> <20050429234952.GB22699@xxxxxxxxxxxxxxxxxxx>
Reply-to: hadi@xxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
On Sat, 2005-30-04 at 09:49 +1000, Herbert Xu wrote:
> On Fri, Apr 29, 2005 at 07:20:46PM -0400, jamal wrote:

> 
> >     write_unlock_bh(&xfrm_policy_lock);
> >  
> > -   if (delpol) {
> > -           xfrm_policy_kill(delpol);
> > +   if (delp) {
> > +           xfrm_policy_kill(delp);
> >     }
> 
> This is racy.  The policy could be killed by the timer in the middle.
> 

the policy_kill is?

> This is also getting pretty hairy for something that nobody has needed so
> far.  Which user-space application is going to use this index thing?

did you see the attachment i put with ip x tests?

cheers,
jamal


<Prev in Thread] Current Thread [Next in Thread>