Re: patch2: del/get byid

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

On Thu, Apr 28, 2005 at 10:20:33AM -0400, jamal wrote:
> 
> Well, heres some minimalist patch i havent tested. i.e doesnt change any
> of the functions; but at least it doesnt break the timers.
> This includes both patches i posted earlier and introduces dir in 
> xfrm_policy. 

Thanks, the dir stuff looks good.

> @@ -345,7 +345,10 @@
>  
>       write_lock_bh(&xfrm_policy_lock);
>       for (p = &xfrm_policy_list[dir]; (pol=*p)!=NULL;) {
> -             if (!delpol && memcmp(&policy->selector, &pol->selector, 
> sizeof(pol->selector)) == 0) {
> +             if (!delpol && 
> +                 ((!excl && policy->index && 
> +                   (policy->index == pol->index)) || 
> +                 (memcmp(&policy->selector, &pol->selector, 
> sizeof(pol->selector)) == 0))) {

Now that you are allowing the user to set the index, this excl check
really needs to go.  Otherwise the user can add two policies with
the same index.

You also still need to solve the problem that you may need to
delete two policies if one matches the index while the other matches
the selector (or selector plus priority if you do that).

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt