Re: [PATCH] cleanups in drivers/net/wan/ - kfree of NULL pointer is vali

To:	Jesper Juhl <juhl-lkml@xxxxxx>
Subject:	Re: [PATCH] cleanups in drivers/net/wan/ - kfree of NULL pointer is valid
From:	Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxx>
Date:	Thu, 28 Apr 2005 19:23:30 -0300
Cc:	netdev@xxxxxxxxxxx, "David S. Miller" <davem@xxxxxxxxxxxxx>, Regina Kodato <reginak@xxxxxxxxxxxx>, pc300@xxxxxxxxxxxx, Nenad Corbic <ncorbic@xxxxxxxxxxx>, Henner Eisen <eis@xxxxxxxxxxxxx>, linux-net@xxxxxxxxxxxxxxx, linux-kernel <linux-kernel@xxxxxxxxxxxxxxx>
In-reply-to:	<Pine.LNX.4.62.0504290009310.2476@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Mail-followup-to:	Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxx>, Jesper Juhl <juhl-lkml@xxxxxx>, netdev@xxxxxxxxxxx, "David S. Miller" <davem@xxxxxxxxxxxxx>, Regina Kodato <reginak@xxxxxxxxxxxx>, pc300@xxxxxxxxxxxx, Nenad Corbic <ncorbic@xxxxxxxxxxx>, Henner Eisen <eis@xxxxxxxxxxxxx>, linux-net@xxxxxxxxxxxxxxx, linux-kernel <linux-kernel@xxxxxxxxxxxxxxx>
References:	<Pine.LNX.4.62.0504290009310.2476@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender:	netdev-bounce@xxxxxxxxxxx
User-agent:	Mutt/1.5.6i

Em Fri, Apr 29, 2005 at 12:22:22AM +0200, Jesper Juhl escreveu:
> kfree(0) is perfectly valid, checking pointers for NULL before calling 
> kfree() on them is redundant. The patch below cleans away a few such 
> redundant checks (and while I was around some of those bits I couldn't 
> stop myself from making a few tiny whitespace changes as well).


Acked-by: Arnaldo Carvalho de MElo <acme@xxxxxxxxxxxxxxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] cleanups in drivers/net/wan/ - kfree of NULL pointer is valid, Jesper Juhl Re: [PATCH] cleanups in drivers/net/wan/ - kfree of NULL pointer is valid, Arnaldo Carvalho de Melo <=

Previous by Date:	[PATCH] cleanups in drivers/net/wan/ - kfree of NULL pointer is valid, Jesper Juhl
Next by Date:	Panic in sk_stream_wait_memory() while doing iSCSI testing, Badari Pulavarty
Previous by Thread:	[PATCH] cleanups in drivers/net/wan/ - kfree of NULL pointer is valid, Jesper Juhl
Next by Thread:	Panic in sk_stream_wait_memory() while doing iSCSI testing, Badari Pulavarty
Indexes:	[Date] [Thread] [Top] [All Lists]