netdev
[Top] [All Lists]

[PATCH] Add more explanation to tcp_prequeue comment

To: netdev@xxxxxxxxxxx
Subject: [PATCH] Add more explanation to tcp_prequeue comment
From: Andrew Grover <andy.grover@xxxxxxxxx>
Date: Thu, 28 Apr 2005 14:14:13 -0700
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition; b=eeIltKSrW01nuwdnnoXPWjBKFtxH2XS/Yldizyr9awEynzYNk7AeWIItu659yJMVqgh8r2x9TnqVPpFxeOcuSNdwv7joTBT6CPaGqWYna9/fivy+gGhQb9Dt005R0tMpDQSw/3lpYQgekMIF8KS6WK9Ei4K7Si7zMUpw7IaT+VQ=
Reply-to: Andrew Grover <andy.grover@xxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
Here's a patch to make that prequeue comment a little clearer. Look ok?

Signed-off-by: Andy Grover <andrew.grover@xxxxxxxxx>

===== include/net/tcp.h 1.105 vs edited =====
--- 1.105/include/net/tcp.h     2005-02-22 10:45:31 -08:00
+++ edited/include/net/tcp.h    2005-04-28 14:02:43 -07:00
@@ -1560,6 +1560,13 @@
  * idea (VJ's mail "Re: query about TCP header on tcp-ip" of 07 Sep 93)
  * failed somewhere. Latency? Burstiness? Well, at least now we will
  * see, why it failed. 8)8)                              --ANK
+ *
+ * Actually, even though the prequeue is not as important for fast
+ * csum anymore, it is important for scheduling, to generate ACKs
+ * when the data is received by the process, not the stack.
+ * davem says, "Without prequeue, we ACK immediately. This artificially
+ * makes the sender believe it can pump data out at that rate to the
+ * receiver."
  *
  * NOTE: is this not too big to inline?
  */


<Prev in Thread] Current Thread [Next in Thread>