netdev
[Top] [All Lists]

Re: [IPSEC]: Kill nested read lock by deleting xfrm_init_tempsel

To: Patrick McHardy <kaber@xxxxxxxxx>
Subject: Re: [IPSEC]: Kill nested read lock by deleting xfrm_init_tempsel
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Thu, 21 Apr 2005 20:13:31 -0700
Cc: herbert@xxxxxxxxxxxxxxxxxxx, kuznet@xxxxxxxxxxxxx, jmorris@xxxxxxxxxx, yoshfuji@xxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <42683D07.6090808@xxxxxxxxx>
References: <20050328233917.GB15369@xxxxxxxxxxxxxxxxxxx> <424B40C2.90304@xxxxxxxxx> <20050331004658.GA26395@xxxxxxxxxxxxxxxxxxx> <20050331212325.5e996432.davem@xxxxxxxxxxxxx> <20050402004956.GA24339@xxxxxxxxxxxxxxxxxxx> <20050401172007.7296eced.davem@xxxxxxxxxxxxx> <20050402020947.GA24998@xxxxxxxxxxxxxxxxxxx> <42501E51.3000401@xxxxxxxxx> <20050405103918.GA24863@xxxxxxxxxxxxxxxxxxx> <4252EEA2.5020107@xxxxxxxxx> <20050406022155.GA12952@xxxxxxxxxxxxxxxxxxx> <20050421163526.7a29a76f.davem@xxxxxxxxxxxxx> <42683D07.6090808@xxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Fri, 22 Apr 2005 01:53:43 +0200
Patrick McHardy <kaber@xxxxxxxxx> wrote:

> Yes, tmpl->id.daddr might be 0, in which case the destination
> of the packet or previous tunnel mode transforms is used. daddr
> always contains the correct adress, so we should use it to check
> for duplicate SPIs. But as Herbert noted, we shouldn't perform
> the check if tmpl->id.spi == 0, so here is a new patch.
> 
> Signed-off-by: Patrick McHardy <kaber@xxxxxxxxx>

Ok, that makes sense.  Patch applied, thanks guys.

<Prev in Thread] Current Thread [Next in Thread>