Re: [IPSEC]: Kill nested read lock by deleting xfrm_init_tempsel

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

On Thu, Apr 21, 2005 at 04:35:26PM -0700, David S. Miller wrote:
>
> > Thanks.  Just one more issue that I can think of, the check should
> > only be done when tmpl->id.spi != 0.  Otherwise the presence of
> > valid states with differing state selectors will prevent new
> > sessions from starting up.
> 
> Is it really worthwhile, right now, to change that tmpl->id.daddr to
> daddr?  That seems to be all that Patrick's most recent patch does.

Yes, because tmpl->id.daddr can be zero when daddr is not zero.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt