netdev
[Top] [All Lists]

Re: [2.6 patch] kill include/linux/eeprom.h

To: Benjamin LaHaise <bcrl@xxxxxxxxx>
Subject: Re: [2.6 patch] kill include/linux/eeprom.h
From: Nick Winlund <nwinlu@xxxxxxxxxxx>
Date: Tue, 19 Apr 2005 07:09:38 -0700
Cc: Adrian Bunk <bunk@xxxxxxxxx>, jgarzik@xxxxxxxxx, linux-net@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20050419135648.GC7315@xxxxxxxxx>
References: <20050419012935.GQ5489@xxxxxxxxx> <20050419135648.GC7315@xxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b) Gecko/20050217
No I think the eeprom routine should be saved as it is now for niche vendors and hobbyists. At the very least an accessible versions repository or CVS containing all prior versions of eeprom implementation should be available, a la a new " bitkeeper " or whatever retrieval interface Linus and collaborators decide on.

One project where linux+eeprom may be used: http://www.ethernut.de/api/if__var_8h.html

Nut OS API

int     NutNetLoadConfig (CONST char *name)
        Load network configuration from EEPROM.
int     NutNetSaveConfig (void)
        Save network configuration in EEPROM.

Nick

Benjamin LaHaise wrote:
At the very least your patch doesn't do a thorough enough job of removing the dead code -- there is no good reason to move the unused code into ns83820.c.

Also, someone needs to go around refactoring eeprom code out of the network drivers at some point.

                -ben
-
To unsubscribe from this list: send the line "unsubscribe linux-net" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



<Prev in Thread] Current Thread [Next in Thread>