| To: | Adrian Bunk <bunk@xxxxxxxxx> |
|---|---|
| Subject: | Re: [2.6 patch] kill include/linux/eeprom.h |
| From: | Benjamin LaHaise <bcrl@xxxxxxxxx> |
| Date: | Tue, 19 Apr 2005 09:56:48 -0400 |
| Cc: | jgarzik@xxxxxxxxx, linux-net@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <20050419012935.GQ5489@xxxxxxxxx> |
| References: | <20050419012935.GQ5489@xxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.4.1i |
At the very least your patch doesn't do a thorough enough job of
removing the dead code -- there is no good reason to move the unused
code into ns83820.c.
Also, someone needs to go around refactoring eeprom code out of the
network drivers at some point.
-ben
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH] Fix deadlock in netconsole with no carrier, Andi Kleen |
|---|---|
| Next by Date: | Re: [2.6 patch] kill include/linux/eeprom.h, Nick Winlund |
| Previous by Thread: | [2.6 patch] kill include/linux/eeprom.h, Adrian Bunk |
| Next by Thread: | Re: [2.6 patch] kill include/linux/eeprom.h, Nick Winlund |
| Indexes: | [Date] [Thread] [Top] [All Lists] |