netdev
[Top] [All Lists]

Re: [Prism54-devel] Question on prism54 driver

To: Rainer Weikusat <rainer.weikusat@xxxxxxxxx>
Subject: Re: [Prism54-devel] Question on prism54 driver
From: Jean-Baptiste Note <jean-baptiste.note@xxxxxxxxxx>
Date: Thu, 14 Apr 2005 13:25:38 +0200
Cc: prism54-devel@xxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <87hdi9sp93.fsf@xxxxxxxxxxxxxxxxx> (Rainer Weikusat's message of "Thu, 14 Apr 2005 11:04:40 +0200")
References: <87fyxu5oin.fsf@xxxxxxxxxxxxxxxxxxxxxx> <87hdi9sp93.fsf@xxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Gnus/5.1007 (Gnus v5.10.7) Emacs/21.4 (gnu/linux)
Hello Rainer, dear list,

First of all, thanks for your quick reply, which is very enlightening.

> <sigh>
> No, you are just hacking the code without even having tried to
> understand
>
>       a) what it is doing
>       b) why it does this
> [which, "by coincedence", happens to be the reason that this driver is
>  so thouroughly broken]
> </sigh>

Please don't let my dumb questions shed a bad light on the prism54
developers as a whole.

I have no doubt that such questions would be obvious to core prism54
developers; i only have reverse-engeneered the softmac usb protocol and
am trying to use the prism54 code to do a pci version of the softmac usb
driver. Rest assured that i will not touch the main prism54 code.

> which means they have to be synced everytime the CPU intends to access
> them after they were accessed by the DMA engine.  The skbuffs used by
> the data transfer code are mapped before they are passed to the device
> and unmapped (which syncs them) before the CPU accesses them. This
> isn't needed for the control block, because it is a consistent and not
> a streaming mapping.

Thank you for taking the time to look into this and answering so
thoroughly. I missed the call to pci_unmap_single, and didn't know about
the consistent mapping meaning.

> BTW, I shouldn't be telling you how your code works, don't you think
> so?

I'm sorry my listing as a prism54 developer may lead to some confusion,
and adversely affect all people in prism54 in addition to making a fool
of myself. This has raised my awareness level. Thanks also for this :)

JB

-- 
Jean-Baptiste Note
+33 (0)6 83 03 42 38
jean-baptiste.note@xxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>