Re: [2/4] [IPSEC] Kill spurious hard expire messages

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

On Sun, Apr 10, 2005 at 10:10:44AM -0400, jamal wrote:
> On Sat, 2005-04-09 at 16:03, Herbert Xu wrote:
> 
> > xfrm_policy_kill can only be called by the one who removed the
> > policy from the linked list.  Therefore it can never fail.
> > 
> > If this logic is wrong we will be getting fat warnings from
> > xfrm_policy_kill.
> 
> The warning will kick in but it may be as rare as the issue of a delete
> and expire happening on the same policy that your patch was supposed to
> stop ;->

What I am saying is that this is impossible.  If it really bothers you
we can turn the WARN_ON into a BUG.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt