netdev
[Top] [All Lists]

Re: [5/*] [IPSEC] Use XFRM_MSG_* instead of XFRM_SAP_*

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [5/*] [IPSEC] Use XFRM_MSG_* instead of XFRM_SAP_*
From: jamal <hadi@xxxxxxxxxx>
Date: 10 Apr 2005 10:15:11 -0400
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, Masahide NAKAMURA <nakam@xxxxxxxxxxxxxx>, Patrick McHardy <kaber@xxxxxxxxx>, netdev <netdev@xxxxxxxxxxx>
In-reply-to: <20050410090250.GA26022@xxxxxxxxxxxxxxxxxxx>
Organization: jamalopolous
References: <1112702604.1089.119.camel@xxxxxxxxxxxxxxxx> <20050409105452.GA7171@xxxxxxxxxxxxxxxxxxx> <20050409111244.GB7171@xxxxxxxxxxxxxxxxxxx> <20050409111551.GA7378@xxxxxxxxxxxxxxxxxxx> <20050410074849.GA13259@xxxxxxxxxxxxxxxxxxx> <20050410090250.GA26022@xxxxxxxxxxxxxxxxxxx>
Reply-to: hadi@xxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
On Sun, 2005-04-10 at 05:02, Herbert Xu wrote:
> Hi:
> 
> I spotted some more issues while preparing the last patch of the
> series.  So I'll extend it a little further.
> 
> This patch removes XFRM_SAP_* and converts them over to XFRM_MSG_*.
> The netlink interface is meant to map directly onto the underlying
> xfrm subsystem.  Therefore rather than using a new independent
> representation for the events we can simply use the existing ones
> from xfrm_user.
> 

The main reason i did the XFRM_SAP_* is to be able to cover a case where
a message was relevant to one KM but not the other. That may not
exist now (actually it does with policy expiration that pfkey cant
handle - but thats easy to take care of).
Hopefully XFRM_MSG_xxx is the superset and will be sufficient.

Do you have anymore patches? If not i can give these a quick test;
Masahide has a better test setup and if he has time he should as well.

cheers,
jamal


<Prev in Thread] Current Thread [Next in Thread>