netdev
[Top] [All Lists]

Re: [Fwd: Re: connector is missing in 2.6.12-rc2-mm1]

To: Thomas Graf <tgraf@xxxxxxx>
Subject: Re: [Fwd: Re: connector is missing in 2.6.12-rc2-mm1]
From: Evgeniy Polyakov <johnpol@xxxxxxxxxxx>
Date: Sun, 10 Apr 2005 16:15:49 +0400
Cc: Kay Sievers <kay.sievers@xxxxxxxx>, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, jmorris@xxxxxxxxxx, ijc@xxxxxxxxxxxxxx, guillaume.thouvenin@xxxxxxxx, greg@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, akpm@xxxxxxxx, netdev@xxxxxxxxxxx, jamal <hadi@xxxxxxxxxx>
In-reply-to: <20050410121005.GF26731@xxxxxxxxxxxxxx>
Organization: MIPT
References: <1112942924.28858.234.camel@uganda> <E1DKZ7e-00070D-00@xxxxxxxxxxxxxxxxxxxxxxxx> <20050410143205.18bff80d@xxxxxxxxxxxxxxxxxxxx> <1113131325.6994.66.camel@xxxxxxxxxxxxxxxxxxxxx> <20050410153757.104fe611@xxxxxxxxxxxxxxxxxxxx> <20050410121005.GF26731@xxxxxxxxxxxxxx>
Reply-to: johnpol@xxxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
On Sun, 10 Apr 2005 14:10:05 +0200
Thomas Graf <tgraf@xxxxxxx> wrote:

> * Evgeniy Polyakov <20050410153757.104fe611@xxxxxxxxxxxxxxxxxxxx> 2005-04-10 
> 15:37
> > --- ./net/netlink/af_netlink.c.orig     2005-04-10 15:46:48.000000000 +0400
> > +++ ./net/netlink/af_netlink.c  2005-04-10 15:47:04.000000000 +0400
> > @@ -747,7 +747,7 @@
> >         if (p->exclude_sk == sk)
> >                 goto out;
> >  
> > -       if (nlk->pid == p->pid || !(nlk->groups & p->group))
> > +       if (nlk->pid == p->pid || (nlk->groups != p->group))
> >                 goto out;
> >  
> >         if (p->failure) {
> 
> Not valid, would break RTMGRP_*.

Yes, it will break too many existing application, 
it would be new API, like do_one_broadcast_direct().
If I understand Kay right, it is what he needs
for the new multicast.

        Evgeniy Polyakov

Only failure makes us experts. -- Theo de Raadt

<Prev in Thread] Current Thread [Next in Thread>