Re: [PATCH 2.6.12-rc2 0/17] bonding: sysfs interface...

[Jay Vosburgh <fubar@xxxxxxxxxx>]

Stephen Hemminger <shemminger@xxxxxxxx> wrote:

[...]
>Also: how do you intend to use the ABI version exported? Unless you have  a 
>clear
>plan, it is frowned upon to drop random version numbers around hoping to be 
>able
>to have compatibility.

        If by "ABI version exported," you're referring to this (and the
associated calls):

+int bond_check_abi_ver(void)
+{
+       int retval = 1;
+ +     if (orig_app_abi_ver == -1) {
+               orig_app_abi_ver  = BOND_ABI_VERSION;
+               app_abi_ver = BOND_ABI_VERSION;
+       }
+       else {
+               if (app_abi_ver == 0)
+                       retval = 0;
+       }
+
+       return retval;
+}
+

        This enforces the already existing ABI version control stuff in
bonding (which deals with different versions of the ifenslave control
program).  This should preserve the existing ifenslave (ioctl based)
ABI.  I've only skimmed the patch, so I haven't tested it out as yet,
but at first glance it looks ok.

        Or did you mean something else?

        -J

---
        -Jay Vosburgh, IBM Linux Technology Center, fubar@xxxxxxxxxx