netdev
[Top] [All Lists]

Re: [PATCH] improvement on net/sched/cls_fw.c's hash function

To: jamal <hadi@xxxxxxxxxx>
Subject: Re: [PATCH] improvement on net/sched/cls_fw.c's hash function
From: Thomas Graf <tgraf@xxxxxxx>
Date: Wed, 6 Apr 2005 15:45:02 +0200
Cc: Wang Jian <lark@xxxxxxxxxxxx>, netdev <netdev@xxxxxxxxxxx>
In-reply-to: <1112794459.1096.61.camel@xxxxxxxxxxxxxxxx>
References: <20050405213023.0256.LARK@xxxxxxxxxxxx> <1112717495.1076.22.camel@xxxxxxxxxxxxxxxx> <20050406143842.026B.LARK@xxxxxxxxxxxx> <20050406123036.GO26731@xxxxxxxxxxxxxx> <1112794459.1096.61.camel@xxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
* jamal <1112794459.1096.61.camel@xxxxxxxxxxxxxxxx> 2005-04-06 09:34
> On Wed, 2005-04-06 at 08:30, Thomas Graf wrote:
> 
> > Let the user specify one of the hash tables via a new TLV:
> >  - default: & 0xFF
> >  - ((mark & mask) >> shift) & 0xFF
> >  - jenkins for 16, 32, and 64 bits
> >  - FNV for 16, 32, and 64 bits
> 
> When does the user specify this? i would think you need to set it once
> only per bootup. After that it will be quiet complex to reset. It could
> be done but sounds complex and unnecessary. i.e it may be a boot or
> module parameter more than it is a netlink controlled value, no?

I'm not 100% sure about this yet but I think during fw_change so
we can have different hashes for different qdiscs filter chains.

<Prev in Thread] Current Thread [Next in Thread>