netdev
[Top] [All Lists]

Re: [IPSEC]: Kill nested read lock by deleting xfrm_init_tempsel

To: Patrick McHardy <kaber@xxxxxxxxx>
Subject: Re: [IPSEC]: Kill nested read lock by deleting xfrm_init_tempsel
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Wed, 6 Apr 2005 12:21:55 +1000
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, kuznet@xxxxxxxxxxxxx, jmorris@xxxxxxxxxx, yoshfuji@xxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <4252EEA2.5020107@xxxxxxxxx>
References: <20050328233917.GB15369@xxxxxxxxxxxxxxxxxxx> <424B40C2.90304@xxxxxxxxx> <20050331004658.GA26395@xxxxxxxxxxxxxxxxxxx> <20050331212325.5e996432.davem@xxxxxxxxxxxxx> <20050402004956.GA24339@xxxxxxxxxxxxxxxxxxx> <20050401172007.7296eced.davem@xxxxxxxxxxxxx> <20050402020947.GA24998@xxxxxxxxxxxxxxxxxxx> <42501E51.3000401@xxxxxxxxx> <20050405103918.GA24863@xxxxxxxxxxxxxxxxxxx> <4252EEA2.5020107@xxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6+20040907i
On Tue, Apr 05, 2005 at 10:01:38PM +0200, Patrick McHardy wrote:
> 
> Good idea, I didn't think of this. This patch is without replacement of
> xfrm_init_tempsel(), it caused an "unused function" warning and, as I
> mentioned before, I still need the function.

Thanks.  Just one more issue that I can think of, the check should
only be done when tmpl->id.spi != 0.  Otherwise the presence of
valid states with differing state selectors will prevent new
sessions from starting up.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

<Prev in Thread] Current Thread [Next in Thread>