netdev
[Top] [All Lists]

Re: [2.6.12-rc1-mm4] swapped memset arguments

To: Jesper Juhl <juhl-lkml@xxxxxx>, Maciej Soltysiak <solt2@xxxxxxxxxxxxxxxxx>
Subject: Re: [2.6.12-rc1-mm4] swapped memset arguments
From: Denis Vlasenko <vda@xxxxxxxxxxxxx>
Date: Tue, 5 Apr 2005 18:37:39 +0300
Cc: "James P. Ketrenos" <ipw2100-admin@xxxxxxxxxxxxxxx>, netdev@xxxxxxxxxxx, "David S. Miller" <davem@xxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <Pine.LNX.4.62.0504030035190.2525@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <74334709.20050402233007@xxxxxxxxxxxxxxxxx> <Pine.LNX.4.62.0504030035190.2525@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: KMail/1.5.4
On Sunday 03 April 2005 01:38, Jesper Juhl wrote:
> On Sat, 2 Apr 2005, Maciej Soltysiak wrote:
> 
> > Hi,
> > 
> > out of boredom I grepped 2.6.12-rc1-mm4 for swapped memset arguments.
> > I found one:
> > 
> > # grep -nr "memset.*\,\(\ \|\)0\(\ \|\));" *
> > net/ieee80211/ieee80211_tx.c:226:       memset(txb, sizeof(struct 
> > ieee80211_txb), 0);  
> > 
> And here's a patch : 
> 
> 
> Fix swapped memset() arguments in  net/ieee80211/ieee80211_tx.c  
> found by Maciej Soltysiak.

This one will stop these from happening again.
(Well, at least on i386)...
--
vda

Attachment: string.diff
Description: Text Data

<Prev in Thread] Current Thread [Next in Thread>