Small change after some testing.
Herbert havent heard back from you - this looks very palatable in my
opinion with comments below still in effect.
cheers,
jamal
On Sat, 2005-04-02 at 14:20, jamal wrote:
> Ok, heres a general patch first cut i think i got all that was discussed
> in there. ive done some basic 5 minutes tests on.
> Once we have agreement i will pass it on to Masahide-san to do more
> thorough testing.
> Look at the XXX comments in the patch.
>
> A couple of interesting things:
>
> 1) Weve discussed this before Herbert and i think you misspoke that
> pfkey delivers to all listerners.
>
> pfkey Add/del/upd now really do tell all processes about what happened.
> Before pfkey would skip the originating process. So far this doesnt seem
> to be an issue in the basic testing.
>
> 2) I ended adding a policy_notify to the pfkey manager to make the code
> generic. Interesting thing is i dont think pfkey knows what to do with
> policy expiration or i am misreading the code.
> I dont see any message type for policy expiration as i do for sa
> expiration. Ive put some hooks and a little noise. I could remove the
> printks - for now they are just place holders.
>
> cheers,
> jamal
ipsec-event-take2-1
Description: Text document
|