netdev
[Top] [All Lists]

Re: [BUG] overflow in net/ipv4/route.c rt_check_expire()

To: Eric Dumazet <dada1@xxxxxxxxxxxxx>
Subject: Re: [BUG] overflow in net/ipv4/route.c rt_check_expire()
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Fri, 1 Apr 2005 15:54:42 -0800
Cc: netdev@xxxxxxxxxxx
In-reply-to: <424DD78D.7070001@xxxxxxxxxxxxx>
References: <42370997.6010302@xxxxxxxxxxxxx> <20050315103253.590c8bfc.davem@xxxxxxxxxxxxx> <42380EC6.60100@xxxxxxxxxxxxx> <20050316140915.0f6b9528.davem@xxxxxxxxxxxxx> <4239E00C.4080309@xxxxxxxxxxxxx> <20050331221352.13695124.davem@xxxxxxxxxxxxx> <424D5D34.4030800@xxxxxxxxxxxxx> <20050401122802.7c71afbc.davem@xxxxxxxxxxxxx> <424DB7A1.8090803@xxxxxxxxxxxxx> <20050401130832.1f972a3b.davem@xxxxxxxxxxxxx> <424DC08A.3020204@xxxxxxxxxxxxx> <20050401143442.62ed8bb9.davem@xxxxxxxxxxxxx> <424DD78D.7070001@xxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Sat, 02 Apr 2005 01:21:49 +0200
Eric Dumazet <dada1@xxxxxxxxxxxxx> wrote:

> OK this patch includes everything...
> 
>   - Locking abstraction
>   - rt_check_expire() fixes
>   - New gc_interval_ms sysctl to be able to have timer gc_interval < 1 second
>   - New gc_debug sysctl to let sysadmin tune gc
>   - Less memory used by hash table (spinlocks moved to a smaller table)
>   - sizing of spinlocks table depends on NR_CPUS
>   - hash table allocated using alloc_large_system_hash() function
>   - header fix for /proc/net/stat/rt_cache

Looks fine to me.

I'd like to see some feedback from folks like Robert Olsson
and co. before applying this, so let's allow the patch to
simmer over the weekend, ok? :-)

<Prev in Thread] Current Thread [Next in Thread>