Re: PATCH: IPSEC xfrm events

[Masahide NAKAMURA <nakam@xxxxxxxxxxxxxx>]

Hello Jamal and Herbert,


jamal wrote:
> Let me review first. If it is valuable (we may have to leave expire
> alone). If i can get it done within next day or two fine - else if i get
> busyed out elsewhere i will hand it to you. Actually if you have plenty
> cycles and are very enthusiastic about this i can hand it to you right
> now ;-> Masahide and myself have some momentum going right now but i
> dont think this will be that disruptive.
> 
> 
>>You're right that the RFC isn't very clear.
>>
>>Let's forget about the RFC and simply consider the usefulness of this.
>>I contend that it is useful to see a FLUSH notification even when
>>it flushed nothing.
>>
>>The reason is that this is an indication to all listeners that the
>>database is completely empty.
>>
> 
> 
> Ok, let me hear from Masahide-san: If he still holds the same opinion as
> you then i will make the change.

I think FLUSH should be sent in such case.
Because flushing empty SADB/SPD is not an error (at current code),
it is reasonable to broadcast it.

Regards,

-- 
Masahide NAKAMURA