netdev
[Top] [All Lists]

Re: [PATCH] netem: account for packets in delayed queue in qlen

To: Stephen Hemminger <shemminger@xxxxxxxx>
Subject: Re: [PATCH] netem: account for packets in delayed queue in qlen
From: Patrick McHardy <kaber@xxxxxxxxx>
Date: Fri, 22 Apr 2005 01:10:25 +0200
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <20050421132020.41858bc4@localhost.localdomain>
References: <20050329152110.38d50653@dxpl.pdx.osdl.net> <4252EB9D.9070305@trash.net> <20050407120417.4297cd14@dxpl.pdx.osdl.net> <42628300.9010007@trash.net> <20050419110639.47767113@localhost.localdomain> <42666098.5060409@trash.net> <20050421132020.41858bc4@localhost.localdomain>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.7.6) Gecko/20050324 Debian/1.7.6-1
Stephen Hemminger wrote:
So duplication is a no go...
Unless there is a different way of accounting for qlen (like a callback).

Instead of a callback you could store parent pointers in struct Qdisc and walk up the tree. One place that would need additional changes to cope with qlen changes of more than 1 is HFSC. It uses q.qlen == 1 as indication that a leaf qdisc was activated by the last enqueue operation. An increment of 2 when q.qlen was 0 before would cause HFSC to forget to activate a class.

Regards
Patrick

<Prev in Thread] Current Thread [Next in Thread>