netdev
[Top] [All Lists]

Re: [PATCH] skb pcount with MTU discovery

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] skb pcount with MTU discovery
From: John Heffner <jheffner@xxxxxxx>
Date: Sat, 2 Apr 2005 10:32:32 -0500 (EST)
Cc: davem@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <E1DHUvP-00050C-00@gondolin.me.apana.org.au>
References: <E1DHUvP-00050C-00@gondolin.me.apana.org.au>
Sender: netdev-bounce@xxxxxxxxxxx
On Sat, 2 Apr 2005, Herbert Xu wrote:

> How about fixing tcp_snd_test directly like this?

I tried that first, but it caused a panic.  I assumed some other point in
the code assumed that invariant that if TSO is disabled then tso_segs==1.
I didn't investigate though.

> Of course all this will be moot once Dave finishes his TSO rewrite :)

That will make things much simpler. ;)

  -John

<Prev in Thread] Current Thread [Next in Thread>