netdev
[Top] [All Lists]

Re: [Patch] net: fix build break when CONFIG_NET_CLS_ACT is not set

To: jamal <hadi@xxxxxxxxxx>
Subject: Re: [Patch] net: fix build break when CONFIG_NET_CLS_ACT is not set
From: Neil Horman <nhorman@xxxxxxxxxx>
Date: Tue, 29 Mar 2005 16:17:41 -0500
Cc: Neil Horman <nhorman@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, "David S. Miller" <davem@xxxxxxxxxxxxx>, netdev <netdev@xxxxxxxxxxx>
In-reply-to: <1112130720.1076.112.camel@xxxxxxxxxxxxxxxx>
References: <20050329202506.GI22447@xxxxxxxxxxxxxxxxxxxxxxxxxxx> <1112130720.1076.112.camel@xxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.1i
On Tue, Mar 29, 2005 at 04:12:01PM -0500, jamal wrote:
> 
> This is being discussed on netdev at the moment. Thomas Graf is working
> on a patch.
> Thanks for the effort though.
> 
> cheers,
> jamal
> 
No worries.  What exactly is the point of contention on netdev? (I'm not
currently following that list).  My patch seems to follow the common practice
for CONFIG_NET_CLS_ACT, in that all references to the action member of the
appropriate struct are themselves ifdef-ed.
Regards,
Neil

> On Tue, 2005-03-29 at 15:25, Neil Horman wrote:
> > Patch to fix build break that occurs when CONFIG_NET_CLS_ACT is not set.
> > 
> > Signed-off-by: Neil Horman <nhorman@xxxxxxxxxx>
> > 
> >  cls_fw.c      |    3 ++-
> >  cls_route.c   |    3 ++-
> >  cls_tcindex.c |    3 ++-
> >  cls_u32.c     |    2 ++
> >  4 files changed, 8 insertions(+), 3 deletions(-)
> > 
> 
> 

-- 
/***************************************************
 *Neil Horman
 *Software Engineer
 *Red Hat, Inc.
 *nhorman@xxxxxxxxxx
 *gpg keyid: 1024D / 0x92A74FA1
 *http://pgp.mit.edu
 ***************************************************/

<Prev in Thread] Current Thread [Next in Thread>