netdev
[Top] [All Lists]

Re: af_packet.c bug?

To: Ben Greear <greearb@xxxxxxxxxxxxxxx>
Subject: Re: af_packet.c bug?
From: Thomas Graf <tgraf@xxxxxxx>
Date: Mon, 28 Mar 2005 21:55:57 +0200
Cc: "'netdev@xxxxxxxxxxx'" <netdev@xxxxxxxxxxx>
In-reply-to: <424858D4.8060604@xxxxxxxxxxxxxxx>
References: <424858D4.8060604@xxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
* Ben Greear <424858D4.8060604@xxxxxxxxxxxxxxx> 2005-03-28 11:19
> 
> What is the '13' doing here?  Maybe it should be IFNAMSIZ?
> 
>       /*
>        *      Find the device first to size check it
>        */
> 
>       saddr->spkt_device[13] = 0;
>       dev = dev_get_by_name(saddr->spkt_device);
>       err = -ENODEV;
>       if (dev == NULL)
>               goto out_unlock;

Seems so, please adopt the size of spkt_device in struct sockaddr_pkt
as well if you change it, it's currently hardcoded as 14.

<Prev in Thread] Current Thread [Next in Thread>