netdev
[Top] [All Lists]

Re: cls_u32 compile failure in current 2.6.12-rc1+BK tree

To: jamal <hadi@xxxxxxxxxx>
Subject: Re: cls_u32 compile failure in current 2.6.12-rc1+BK tree
From: Thomas Graf <tgraf@xxxxxxx>
Date: Mon, 28 Mar 2005 21:53:20 +0200
Cc: Meelis Roos <mroos@xxxxxxxx>, netdev <netdev@xxxxxxxxxxx>
In-reply-to: <1112038128.1119.5.camel@xxxxxxxxxxxxxxxx>
References: <Pine.SOC.4.61.0503272249040.5086@xxxxxxxxxx> <1111972035.1091.946.camel@xxxxxxxxxxxxxxxx> <Pine.SOC.4.61.0503281017060.21333@xxxxxxxxxx> <1112012657.1089.1013.camel@xxxxxxxxxxxxxxxx> <20050328123801.GY3086@xxxxxxxxxxxxxx> <1112014261.1089.1018.camel@xxxxxxxxxxxxxxxx> <20050328125802.GZ3086@xxxxxxxxxxxxxx> <1112015725.1089.1045.camel@xxxxxxxxxxxxxxxx> <20050328155523.GD3086@xxxxxxxxxxxxxx> <1112038128.1119.5.camel@xxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
* jamal <1112038128.1119.5.camel@xxxxxxxxxxxxxxxx> 2005-03-28 14:28
> On Mon, 2005-03-28 at 10:55, Thomas Graf wrote:
> > * jamal <1112015725.1089.1045.camel@xxxxxxxxxxxxxxxx> 2005-03-28 08:15
> > > On Mon, 2005-03-28 at 07:58, Thomas Graf wrote:
> 
> > > But you cant completely do this for u32 tcf_exts_dump_stats.
> > > in the case of ACTION compiled in but someone using old API.
> > > The code that Meelis just mention that compiler complained about. 
> > > There was no problem with u32 and tcf_exts_dump - with that you can hide
> > > all #ifedfs. 
> > 
> > I think we can avoid your fixes. 
> 
> You are still missing the question;->
> 
> You can do this for every classifier but u32. Or is it me who is missing
> something?

I think what you are refering to is the TC_U32_KEY() check, right?
If you look at the place where tcf_exts_dump is called you can
see that the same pre condition is given since the call is in a
else branch of a TC_U32_KEY() == 0 condition.

I haven't had the time to come up with a patch, too many other
things to take care of but I think it should work out ok.

<Prev in Thread] Current Thread [Next in Thread>