| To: | Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [NET] make all protos partially use sk_prot |
| From: | Marcel Holtmann <marcel@xxxxxxxxxxxx> |
| Date: | Sat, 26 Mar 2005 14:36:03 +0100 |
| Cc: | Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Network Development Mailing List <netdev@xxxxxxxxxxx> |
| In-reply-to: | <39e6f6c7050326051571ef8272@xxxxxxxxxxxxxx> |
| References: | <20050326003937.GA13951@xxxxxxxxxxxxxxxx> <1111842541.9195.183.camel@pegasus> <39e6f6c705032605136bd797b2@xxxxxxxxxxxxxx> <39e6f6c7050326051571ef8272@xxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
Hi Arnaldo, > Ah, apart from these style changes, do you think the real changes in this > patch > are worth? actually I am the wrong person to judge on this. However if socket users don't have to care about owner and slab anymore (or at least less), I think it is a good thing to do. Btw all the ".slab = NULL," stuff in the proto declarations is not needed and we normally omit values that are 0 or NULL. And some of the proto__seq_* functions are not static. What is the reason to have them public? Regards Marcel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [NET] make all protos partially use sk_prot, Arnaldo Carvalho de Melo |
|---|---|
| Next by Date: | Re: [NET] make all protos partially use sk_prot, Arnaldo Carvalho de Melo |
| Previous by Thread: | Re: [NET] make all protos partially use sk_prot, Arnaldo Carvalho de Melo |
| Next by Thread: | Re: [NET] make all protos partially use sk_prot, Arnaldo Carvalho de Melo |
| Indexes: | [Date] [Thread] [Top] [All Lists] |