netdev
[Top] [All Lists]

Re: [NET] make all protos partially use sk_prot

To: Marcel Holtmann <marcel@xxxxxxxxxxxx>
Subject: Re: [NET] make all protos partially use sk_prot
From: Arnaldo Carvalho de Melo <arnaldo.melo@xxxxxxxxx>
Date: Sat, 26 Mar 2005 10:15:34 -0300
Cc: Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Network Development Mailing List <netdev@xxxxxxxxxxx>
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:references; b=dfhXlqe32AbZJsbfZM0B2pwmc5xV763zxUYs+slvfSK3anytgLn7xOF//BYO1AcbE4Ghi1SuLqBJSbiGvFTeYk+PG5tmT66vS3O+2oRt3rtWP8l004cXBMeXLrodhOnshAZLPTiKIOLBzBHTXBhRCMh21rw1xkOSLYhOotOHOOk=
In-reply-to: <39e6f6c705032605136bd797b2@xxxxxxxxxxxxxx>
References: <20050326003937.GA13951@xxxxxxxxxxxxxxxx> <1111842541.9195.183.camel@pegasus> <39e6f6c705032605136bd797b2@xxxxxxxxxxxxxx>
Reply-to: acme@xxxxxxxxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
On Sat, 26 Mar 2005 10:13:31 -0300, Arnaldo Carvalho de Melo
<arnaldo.melo@xxxxxxxxx> wrote:
> On Sat, 26 Mar 2005 14:09:01 +0100, Marcel Holtmann <marcel@xxxxxxxxxxxx> 
> wrote:
> > Hi Arnaldo,
> >
> > >       Please take a look and apply if acceptable, full description is
> > > on the changeset.
> > >
> > >       Ah, I started using __ as a separator between class name and
> > > method, I've been using this in some client projects and find it useful
> > > for grepping and for ctags, as it eliminates some false positives and
> > > do namespacing more strongly, please tell me if you don't like it.
> > >
> > >       If this is accepted the next changesets probably will move
> > > struct proto and the proto__ routines to net/core/prot.{c,h} and I'll
> > > add proto__ prefix to all struct proto members, etc.
> >
> > I personally don't like the __ separator thing. Is this really needed?
> > What is wrong with using "proto_register()"? Where is the advantage?
> 
> Well, I stated it above, but if there are strong feelings like yours,
> I'll humbly
> retract that
> 
> > And please don't convert from using "err" to "rc" for the return value
> > of the init function. In the case of the Bluetooth subsystem we never
> > call these variables "rc" and thus you are messing things up.
> 
> Consistency, but again, strong feelings, so I'll rework the patch
> removing the __
> and removing the style changes I did to your subsystem.

Ah, apart from these style changes, do you think the real changes in this patch
are worth?

- Arnaldo

<Prev in Thread] Current Thread [Next in Thread>