Re: memory leak in net/sched/ipt.c?

[jamal <hadi@xxxxxxxxxx>]

On Wed, 2005-03-23 at 06:30, Herbert Xu wrote:
> Yichen Xie <yxie@xxxxxxxxxxxxxxx> wrote:
> > Is the memory block allocated on line 315 leaked every time tcp_ipt_dump 
> > is called?
> 
> It seems to be.  This patch should free it.
> 
> Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> 
> BTW, please report networking bugs to netdev@xxxxxxxxxxxx
> 

Thanks for pointing this out - I _know_ its in the kernel list FAQ.
I was sitting beside R Gooch when he added "thou shalt post to netdev".
And of course i am gonna bitch about it every time someone doesnt
post to netdev;-> 

Just a small correction to patchlet:
The second kfree should check for existence of t.

cheers,
jamal

> Thanks,