On Sun, 2005-03-20 at 14:22, Patrick McHardy wrote:
> Jamal Hadi Salim wrote:
> > Ive posted this before - dont want it to sit here rotting.
> > If theres nothing glaringly wrong with it (Thomas/Patrick?) then Dave
> > please apply so i can start shooting other patches based on it.
> Any reasons why all of these need to be inline functions?
A lot of the code is very common.
I am essentially sticking some common code as inlines to allow someone
to write some very simple code - probably just the packet processing
function - see attached simple action.
Inlines seem easy to allow this.
> One of the next things I wanted to do in this area was
> moving all the large inline functions to act_generic.c,
> so if possible I would prefer not to put these in a header
These are small functions. Take a look at the simple action i attached.
If you can give me the same functionality and still move things
de_inlined to act_generic.c i would be fine with it.
Description: Text document