Re: [2.6 patch] net/ipv4/inetpeer.c: make a struct static

netdev

Re: [2.6 patch] net/ipv4/inetpeer.c: make a struct static

To:	"David S. Miller" <davem@xxxxxxxxxxxxx>
Subject:	Re: [2.6 patch] net/ipv4/inetpeer.c: make a struct static
From:	"David S. Miller" <davem@xxxxxxxxxxxxx>
Date:	Wed, 16 Mar 2005 14:54:48 -0800
Cc:	bunk@xxxxxxxxx, netdev@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to:	<20050316145343.6e31ba6a.davem@xxxxxxxxxxxxx>
References:	<20050315144408.GL3189@xxxxxxxxx> <20050316145343.6e31ba6a.davem@xxxxxxxxxxxxx>
Sender:	netdev-bounce@xxxxxxxxxxx

On Wed, 16 Mar 2005 14:53:43 -0800
"David S. Miller" <davem@xxxxxxxxxxxxx> wrote:

> On Tue, 15 Mar 2005 15:44:08 +0100
> Adrian Bunk <bunk@xxxxxxxxx> wrote:
> 
> > This patch makes a needlessly global struct static.
> > 
> > Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>
> 
> You need to also kill the externs in net/inetpeer.h
> 
> Please fix this up and resubmit.

Actually, Adrian, net/inetpeer.h makes use of
inet_peer_unused_tailp in inline functions.

How did you get a successful build after marking
it static?

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[2.6 patch] net/ipv4/inetpeer.c: make a struct static, Adrian Bunk Re: [2.6 patch] net/ipv4/inetpeer.c: make a struct static, David S. Miller Re: [2.6 patch] net/ipv4/inetpeer.c: make a struct static, David S. Miller <= [2.6 patch] net/ipv4/inetpeer.c: make a struct static, Adrian Bunk Re: [2.6 patch] net/ipv4/inetpeer.c: make a struct static, David S. Miller

Previous by Date:	Re: [2.6 patch] net/ipv4/inetpeer.c: make a struct static, David S. Miller
Next by Date:	[RFT 1/3] 8139: safer spin loop for get_statistics, Stephen Hemminger
Previous by Thread:	Re: [2.6 patch] net/ipv4/inetpeer.c: make a struct static, David S. Miller
Next by Thread:	[2.6 patch] net/ipv4/inetpeer.c: make a struct static, Adrian Bunk
Indexes:	[Date] [Thread] [Top] [All Lists]