| To: | "David S. Miller" <davem@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx |
|---|---|
| Subject: | [PATCH] reduce sizeof(struct inet_peer) from 128 to 64 bytes on 64bits architectures |
| From: | Eric Dumazet <dada1@xxxxxxxxxxxxx> |
| Date: | Wed, 16 Mar 2005 19:05:45 +0100 |
| In-reply-to: | <42380EC6.60100@xxxxxxxxxxxxx> |
| References: | <42370997.6010302@xxxxxxxxxxxxx> <20050315103253.590c8bfc.davem@xxxxxxxxxxxxx> <42380EC6.60100@xxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.3) Gecko/20040910 |
As peer_cachep uses kmem_cache_create("inet_peer_cache", ... SLAB_HWCACHE_ALIGN
...),
better try to use exactly 64 bytes instead of 72 for struct inet_peer.
This also means that this structure fits in one cache line on x86_64.
Thank you
Eric Dumazet
# diff -Nru linux-2.6.11/include/net/inetpeer.h
linux-2.6.11-ed/include/net/inetpeer.h
--- linux-2.6.11/include/net/inetpeer.h 2005-03-02 08:37:48.000000000 +0100
+++ linux-2.6.11-ed/include/net/inetpeer.h 2005-03-16 18:52:49.000000000
+0100
@@ -19,9 +19,9 @@
{
struct inet_peer *avl_left, *avl_right;
struct inet_peer *unused_next, **unused_prevp;
- atomic_t refcnt;
unsigned long dtime; /* the time of last use of not
* referenced entries */
+ atomic_t refcnt;
__u32 v4daddr; /* peer's address */
__u16 avl_height;
__u16 ip_id_count; /* IP ID for the next packet */
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: limit ssh, Matt Mackall |
|---|---|
| Next by Date: | Re: [patch 06/13] ppc 8260 fcc ethernet driver cannot read LXT971 PHY id, Jeff Garzik |
| Previous by Thread: | [BUG] overflow in net/ipv4/route.c rt_check_expire(), Eric Dumazet |
| Next by Thread: | Re: [PATCH] reduce sizeof(struct inet_peer) from 128 to 64 bytes on 64bits architectures, David S. Miller |
| Indexes: | [Date] [Thread] [Top] [All Lists] |