| To: | Nivedita Singhvi <niv@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] Optimize loopback stats |
| From: | Nivedita Singhvi <niv@xxxxxxxxxx> |
| Date: | Tue, 15 Mar 2005 16:18:42 -0800 |
| Cc: | Chuck Ebbert <76306.1226@xxxxxxxxxxxxxx>, Christoph Lameter <clameter@xxxxxxx>, Andrew Morton <akpm@xxxxxxxx>, linux-netdev <netdev@xxxxxxxxxxx> |
| In-reply-to: | <42377947.5090207@xxxxxxxxxx> |
| References: | <200503151819_MC3-1-98A4-43AC@xxxxxxxxxxxxxx> <42377947.5090207@xxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041217 |
Hmm, I see the following in your patch: + stats->rx_bytes += lb_stats->rx_tx_bytes; + stats->tx_bytes = stats->rx_bytes; Doesn't that mean RX is now twice what it should be and so is TX? They are separately reported, but if so, their real value should be half of rx_tx_bytes each, correct? Ah, just beat me silly with a cluestick. I see what you're doing now..it's fine. thanks, Nivedita |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] Optimize loopback stats, Nivedita Singhvi |
|---|---|
| Next by Date: | Re: [patch 2.6.11] bonding: avoid tx balance for IGMP (alb/tlb mode), Rick Jones |
| Previous by Thread: | Re: [PATCH] Optimize loopback stats, Nivedita Singhvi |
| Next by Thread: | [patch 2.6.11] bonding: avoid tx balance for IGMP (alb/tlb mode), John W. Linville |
| Indexes: | [Date] [Thread] [Top] [All Lists] |