netdev
[Top] [All Lists]

Re: [PATCH] Optimize loopback stats

To: Chuck Ebbert <76306.1226@xxxxxxxxxxxxxx>
Subject: Re: [PATCH] Optimize loopback stats
From: Nivedita Singhvi <niv@xxxxxxxxxx>
Date: Tue, 15 Mar 2005 12:49:51 -0800
Cc: linux-netdev <netdev@xxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxx>, Christoph Lameter <clameter@xxxxxxx>
In-reply-to: <4237423E.2040505@xxxxxxxxxx>
References: <200503151459_MC3-1-989A-61A4@xxxxxxxxxxxxxx> <4237423E.2040505@xxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041217
Nivedita Singhvi wrote:
Chuck Ebbert wrote:

  This patch optimizes the loopback driver's statistics by using a single
counter for rx and tx stats instead of one for rx and one for tx. It also adds unlikely() to the test for TSO since it's no longer supported by default.
(Maybe the TSO code should be bracketed by "#if 0" ?)


Hmm, some of us want those counters separate - if this is really
needed, could it be a configurable option, please?

Or we could live with the appropriate patches to ip, ifconfig,
reporting them separately (halving them). That would be fine.

thanks,
Nivedita



<Prev in Thread] Current Thread [Next in Thread>