[Top] [All Lists]

Re: [14/*] [IPV6] Reload skb->dst after xfrm6_route_forward

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [14/*] [IPV6] Reload skb->dst after xfrm6_route_forward
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Mon, 14 Mar 2005 21:27:28 -0800
Cc: kuznet@xxxxxxxxxxxxx, yoshfuji@xxxxxxxxxxxxxx, kaber@xxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20050314111002.GA29156@xxxxxxxxxxxxxxxxxxx>
References: <20050214221006.GA18415@xxxxxxxxxxxxxxxxxxx> <20050214221200.GA18465@xxxxxxxxxxxxxxxxxxx> <20050214221433.GB18465@xxxxxxxxxxxxxxxxxxx> <20050214221607.GC18465@xxxxxxxxxxxxxxxxxxx> <20050306213214.7d8a143d.davem@xxxxxxxxxxxxx> <20050307103536.GB7137@xxxxxxxxxxxxxxxxxxx> <20050308102741.GA23468@xxxxxxxxxxxxxxxxxxx> <20050314102614.GA9610@xxxxxxxxxxxxxxxxxxx> <20050314105313.GA21001@xxxxxxxxxxxxxxxxxxx> <20050314111002.GA29156@xxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Mon, 14 Mar 2005 22:10:02 +1100
Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:

> While replacing dst_pmtu in ip6_output I found this little gem.  In
> ip6_forward we're not reloading the dst pointer after calling
> xfrm6_route_forward.  So all subsequent dereferences of dst will
> refer to its pre-IPsec value.
> The solution is of course to refresh its value.
> Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

Good catch Herbert.

Applied, thanks.

<Prev in Thread] Current Thread [Next in Thread>