netdev
[Top] [All Lists]

Re: ip6t_LOG.c: patch killing spaces on ouput of IPv4 address on TUNNEL=

To: Harald Welte <laforge@xxxxxxxxxxxx>
Subject: Re: ip6t_LOG.c: patch killing spaces on ouput of IPv4 address on TUNNEL=
From: Peter Bieringer <pb@xxxxxxxxxxxx>
Date: Mon, 14 Mar 2005 20:52:27 +0100
Cc: Maillist netdev <netdev@xxxxxxxxxxx>, David Miller <davem@xxxxxxxxxx>
In-reply-to: <20050314080628.GE19298@xxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <DB755B5F6CF46771B8607810@xxxxxxxxxxxxxxxxxxxxxxx> <20050314080628.GE19298@xxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx

--On Monday, March 14, 2005 09:06:28 AM +0100 Harald Welte
<laforge@xxxxxxxxxxxx> wrote:

> On Sat, Mar 05, 2005 at 05:01:53PM +0100, Peter Bieringer wrote:
>> Hi,
>> 
>> I'm still wondering that this was never fixed since 3 years:
> 
> Because it presumably breaks existing scripts that expect it to be in
> the broken (speced) format.

How many scripts are already parsing IPv6 log lines? Show me one, please. I
believe I'm the only one who really looked into the logs because I saw
nobody else ever claiming about the broken printout.

> I'm not particularly for or against that change... but whatever I do,
> somebody will always be complaining.  To make you happy and have someone
> else complain next time ;)

I don't believe that it is a good idea to let broken log output long time
in the kernel, especially in IPv6 world, where changes still ongoing in
current Linux kernel. How longer you wait the more will ran (perhaps) into
temporary trouble.

For all the script writers, add a module option like "broken_log_lines=yes"
;-)

Regards,
       Peter
-- 
Dr. Peter Bieringer                     http://www.bieringer.de/pb/
GPG/PGP Key 0x958F422D               mailto: pb at bieringer dot de 
Deep Space 6 Co-Founder and Core Member  http://www.deepspace6.net/
> 
> Signed-off-by: Harald Welte <laforge@xxxxxxxxxxxxx>



<Prev in Thread] Current Thread [Next in Thread>