netdev
[Top] [All Lists]

Re: [PATCH 4/5] r8169: ethtool message level control

To: Stephen Hemminger <shemminger@xxxxxxxx>
Subject: Re: [PATCH 4/5] r8169: ethtool message level control
From: Richard Dawe <rich@xxxxxxxxxxxxxxxxxxxx>
Date: Sat, 12 Mar 2005 12:02:23 +0000
Cc: Francois Romieu <romieu@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <20050309113402.05d25e49@xxxxxxxxxxxxxxxxx>
References: <20050309113402.05d25e49@xxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20041020
Hello.

Stephen Hemminger wrote:
Add ethtool message level control support. This is the standard way
to enable/disable console log messages.  Also, ratelimit the too much
work at interrupt message, so if under massive packet load the console
doesn't get flooded.

Signed-off-by: Stephen Hemminger <shemminger@xxxxxxxx>

diff -Nru a/drivers/net/r8169.c b/drivers/net/r8169.c
--- a/drivers/net/r8169.c       2005-03-09 11:25:04 -08:00
+++ b/drivers/net/r8169.c       2005-03-09 11:25:04 -08:00
[snip]
@@ -875,12 +885,26 @@
         spin_unlock_irqrestore(&tp->lock, flags);
 }
+static u32 rtl8169_get_msglevel(struct net_device *dev)
+{
+        struct rtl8169_private *tp = netdev_priv(dev);
+       return tp->msg_enable;
+}
+
+static void rtl8169_set_msglevel(struct net_device *dev, u32 value)
+{
+        struct rtl8169_private *tp = netdev_priv(dev);
+       tp->msg_enable = value;
+}
+
[snip]

When I posted a patch for message level support a couple of weeks ago (and got a ton of corrective feedback), Francois asked that there be whitespace separating the definitions from executable code in these functions.

Bye, Rich =]

--
Richard Dawe [ http://homepages.nildram.co.uk/~phekda/richdawe/ ]

"You can't evaluate a man by logic alone."
  -- McCoy, "I, Mudd", Star Trek

<Prev in Thread] Current Thread [Next in Thread>