netdev
[Top] [All Lists]

Re: [PATCH 1/5] r8169: auto detect 32-bit slot

To: Jon Mason <jdmason@xxxxxxxxxx>
Subject: Re: [PATCH 1/5] r8169: auto detect 32-bit slot
From: Francois Romieu <romieu@xxxxxxxxxxxxx>
Date: Thu, 10 Mar 2005 12:17:03 +0100
Cc: Andi Kleen <ak@xxxxxx>, Stephen Hemminger <shemminger@xxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <200503092214.10348.jdmason@xxxxxxxxxx>
References: <20050309112925.7f7900ab@xxxxxxxxxxxxxxxxx> <200503091608.59122.jdmason@xxxxxxxxxx> <20050309223943.GB9502@xxxxxxxxxxxxxxxxxxxxxxxxxx> <200503092214.10348.jdmason@xxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.1i
Jon Mason <jdmason@xxxxxxxxxx> :
[...]
> +       if ((sizeof(dma_addr_t) > 4) &&
> +           (RTL_R32(Config2) & (1<<3)) && 
> +           !pci_set_dma_mask(pdev, DMA_64BIT_MASK)) {
> 
> For the above, I get 8 0 1 respectively.  So, my adapters fail because of the 
> 64bit slot test.  

Config2 can not be a replacement for "use_dac" then.

> If you like, I can try my stand-alone adapter in a 64bit slot of a ppc64 
> system.

It is not strictly necessary. Config2 ought to identify the 64bit slot at best.

Thanks.

--
Ueimor

<Prev in Thread] Current Thread [Next in Thread>