netdev
[Top] [All Lists]

Re: [XFRM]: Fix ICMP tempsel

To: Patrick McHardy <kaber@xxxxxxxxx>
Subject: Re: [XFRM]: Fix ICMP tempsel
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Wed, 9 Mar 2005 20:49:47 -0800
Cc: herbert@xxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <4217266F.6090700@xxxxxxxxx>
References: <4217266F.6090700@xxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Sat, 19 Feb 2005 12:43:43 +0100
Patrick McHardy <kaber@xxxxxxxxx> wrote:

> The selector ports are initialized to fl_ip_sport/fl_ip_dport instead
> of xfrm_flowi_sport(fl)/xfrm_flowi_dport(fl). This is wrong for ICMP,
> type and code should be stored in sport and dport, in struct flowi both
> are contained in fl_ip_sport.

This resulted in a long thread, many newer versions of the patch
trying to clean this up in other ways, but then we determined that
this original patch was the best and safest fix for now.

So I applied this first patch.

Thanks everyone.

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [XFRM]: Fix ICMP tempsel, David S. Miller <=