netdev
[Top] [All Lists]

Re: [PATCH 5/5] r8169: ethtool hardware statistics support

To: Stephen Hemminger <shemminger@xxxxxxxx>
Subject: Re: [PATCH 5/5] r8169: ethtool hardware statistics support
From: Jon Mason <jdmason@xxxxxxxxxx>
Date: Wed, 9 Mar 2005 22:21:48 -0600
Cc: Francois Romieu <romieu@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <20050309135345.5efae9b6@xxxxxxxxxxxxxxxxx>
Organization: IBM
References: <20050309113626.6708c93e@xxxxxxxxxxxxxxxxx> <200503091537.30899.jdmason@xxxxxxxxxx> <20050309135345.5efae9b6@xxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: KMail/1.7.2
On Wednesday 09 March 2005 03:53 pm, Stephen Hemminger wrote:
> On Wed, 9 Mar 2005 15:37:30 -0600
>
> Jon Mason <jdmason@xxxxxxxxxx> wrote:
> > Does this patch fix the problem of bogus statistics if the interface is
> > down
>
> I see no problem when interface is down. It returns all zero's because
> the device is reset on probe (and on shutdown).

I can confirm that I see no statistic errors either. 

I believe the faulty code in Richard's patch was:
+       if (RTL_R32(StatsAddrLow) & DumpStats)
+               return; /* no stats - took too long */

Which returned before the stats were populated (leaving garbage).  Since your 
patch lacks this, we see no problem.  If this is true, there is probably a 
problem on 8139cp, which has a similar error path in its cp_get_ethtool_stats 
function.   

Thanks,
Jon

<Prev in Thread] Current Thread [Next in Thread>