netdev
[Top] [All Lists]

Re: [PATCH 2/11] [NET] Convert sk_zapped into SOCK_ZAPPED flag

To: Thomas Graf <tgraf@xxxxxxx>
Subject: Re: [PATCH 2/11] [NET] Convert sk_zapped into SOCK_ZAPPED flag
From: Patrick McHardy <kaber@xxxxxxxxx>
Date: Wed, 09 Mar 2005 21:05:50 +0100
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <20050309195649.GT31837@xxxxxxxxxxxxxx>
References: <20050309194521.GH31837@xxxxxxxxxxxxxx> <20050309194711.GJ31837@xxxxxxxxxxxxxx> <422F5461.4080008@xxxxxxxxx> <20050309195649.GT31837@xxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.7.5) Gecko/20050106 Debian/1.7.5-1
Thomas Graf wrote:
* Patrick McHardy <422F5461.4080008@xxxxxxxxx> 2005-03-09 20:54

What about volatile ? sock_set_flag() uses __set_bit(), so its not
the same.


I thought about this for a while but couldn't find a reason
why it shouldn't work. Actually I don't even see any reason for
having sk_zapped be volatile.

You're probably right. I believe this piece of code from 2.4 is the
reason for it beeing volatile:

#ifdef TCP_DEBUG
        if (sk->zapped) {
                printk(KERN_DEBUG "TCP: double destroy sk=%p\n", sk);
                sock_hold(sk);
        }
        sk->zapped = 1;
#endif

Regards
Patrick

<Prev in Thread] Current Thread [Next in Thread>