netdev
[Top] [All Lists]

Re: [PATCH][BLUETOOTH] kill bt_sock_alloc

To: Max Krasnyansky <maxk@xxxxxxxxxxxx>
Subject: Re: [PATCH][BLUETOOTH] kill bt_sock_alloc
From: Arnaldo Carvalho de Melo <arnaldo.melo@xxxxxxxxx>
Date: Wed, 9 Mar 2005 14:43:54 -0300
Cc: marcel@xxxxxxxxxxxx, davem@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:references; b=D8tBlGCblFnS2GOze7OaDLwArecVFgvsf30kb8mkiWyujjRMW6W9BIWOpdMRfaTi4rzGN2gk8RjJpFMQGfLrWESYEFIhm6sXDushKal7afMQHRUJ6iuu9IlaPpBvkiYmLwtaAyLd2w49oc9aa5qEERApO2C03nwI/ebjMPnCCsU=
In-reply-to: <422F33E9.4030401@xxxxxxxxxxxx>
References: <20050308094937.GA9468@xxxxxxxxxxxxxxxx> <20050308095209.GB9468@xxxxxxxxxxxxxxxx> <422F33E9.4030401@xxxxxxxxxxxx>
Reply-to: acme@xxxxxxxxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
On Wed, 09 Mar 2005 09:35:37 -0800, Max Krasnyansky <maxk@xxxxxxxxxxxx> wrote:
> Arnaldo Carvalho de Melo wrote:
> > Em Tue, Mar 08, 2005 at 06:49:37AM -0300, Arnaldo Carvalho de Melo escreveu:
> >
> >>Hi,
> >>
> >>      Please take a look and if acceptable pull from:
> >>
> >>bk://kernel.bkbits.net/acme/connection_sock-2.6
> >
> >
> > Sorry, now with the patch attached.
> 
> Looks good to me. Marcel I'd suggest for you to apply this patch.
> It helps in reducing overall size of the socket structures.

Please note that there are further space savings to tap into in the bt_sock
class hierarchy, as not all of the bt_sock descendants  needs things like
bt_sock::accept_q,  etc

And when the "kill sk_protinfo" series is finished, there will be further space
savings, as the same bt_sock descendants that don't use accept_q will not
need to have struct connection_sock in its definition.

-- 
- Arnaldo

<Prev in Thread] Current Thread [Next in Thread>