netdev
[Top] [All Lists]

Re: [leo@xxxxxxxxx: [PATCH] ethernet-bridge: update skb->priority in cas

To: Ben Greear <greearb@xxxxxxxxxxxxxxx>
Subject: Re: [leo@xxxxxxxxx: [PATCH] ethernet-bridge: update skb->priority in case forwarded frame has VLAN-header]
From: jamal <hadi@xxxxxxxxxx>
Date: 08 Mar 2005 16:43:41 -0500
Cc: Patrick McHardy <kaber@xxxxxxxxx>, leo@xxxxxxxxx, Lennert Buytenhek <buytenh@xxxxxxxxxxxxxx>, shemminger@xxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <422DE4B0.6040201@xxxxxxxxxxxxxxx>
Organization: jamalopolous
References: <20050305141225.GA5180@xxxxxxxxxxxxxxxxx> <4229D98F.9010008@xxxxxxxxx> <422A0C21.3050709@xxxxxxxxxxxxxxx> <1110199696.1094.1299.camel@xxxxxxxxxxxxxxxx> <Pine.LNX.4.62.0503072034340.5934@xxxxxxxxxxxxxxxxxx> <1110238537.1043.62.camel@xxxxxxxxxxxxxxxx> <422CE983.7060305@xxxxxxxxx> <1110241190.1043.100.camel@xxxxxxxxxxxxxxxx> <422D1E26.1010902@xxxxxxxxx> <1110287626.1043.146.camel@xxxxxxxxxxxxxxxx> <422DE4B0.6040201@xxxxxxxxxxxxxxx>
Reply-to: hadi@xxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
On Tue, 2005-03-08 at 12:45, Ben Greear wrote:
[..]
> jamal wrote:
> > I think you still want (perhaps the vlan) driver to come up with some
> > sane defaults. From what i read from bgrear he has arbitrary values.
> 
> By default, everything is mapped to priority of zero, but the user can
> specify a mapping to any integer they desire.
>
> If you have some suggestions for some defaults better than zero, I'm
> willing to consider it.
> 

Everything going to zero may not be such a bad default.
You could do better by creating a map that resembles what
the default 3 band scheduler does. Just keep in mind that  
the reverse semantics of priorities. If you need help we can take it
offline.

cheers,
jamal


<Prev in Thread] Current Thread [Next in Thread>