netdev
[Top] [All Lists]

Re: [leo@xxxxxxxxx: [PATCH] ethernet-bridge: update skb->priority in cas

To: jamal <hadi@xxxxxxxxxx>
Subject: Re: [leo@xxxxxxxxx: [PATCH] ethernet-bridge: update skb->priority in case forwarded frame has VLAN-header]
From: Patrick McHardy <kaber@xxxxxxxxx>
Date: Mon, 7 Mar 2005 20:36:35 +0100 (CET)
Cc: Ben Greear <greearb@xxxxxxxxxxxxxxx>, leo@xxxxxxxxx, Lennert Buytenhek <buytenh@xxxxxxxxxxxxxx>, shemminger@xxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <1110199696.1094.1299.camel@xxxxxxxxxxxxxxxx>
References: <20050305141225.GA5180@xxxxxxxxxxxxxxxxx> <4229D98F.9010008@xxxxxxxxx> <422A0C21.3050709@xxxxxxxxxxxxxxx> <1110199696.1094.1299.camel@xxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Mon, 7 Mar 2005, jamal wrote:

This is wrong. IEEE priorities are opposite of IETF priorities (as used by
skb->prio).
Unless you install a prio qdisc and rewrite the priomap, you are screwed.
So you should do opposite mapping, i.e something along the lines of
VLAN_TCI priority (0..7) to skb->priority (15..8) i,e

skb->priority = 15 - vlan_TCI;

The priority should still start at 0. You don't want to create a 16-band
queue just to have 8 bands unused.

Regards
Patrick

<Prev in Thread] Current Thread [Next in Thread>