netdev
[Top] [All Lists]

Re: [leo@xxxxxxxxx: [PATCH] ethernet-bridge: update skb->priority in cas

To: Stephen Hemminger <shemminger@xxxxxxxx>
Subject: Re: [leo@xxxxxxxxx: [PATCH] ethernet-bridge: update skb->priority in case forwarded frame has VLAN-header]
From: Patrick McHardy <kaber@xxxxxxxxx>
Date: Mon, 07 Mar 2005 19:16:50 +0100
Cc: Ben Greear <greearb@xxxxxxxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <20050307100744.429e100a@xxxxxxxxxxxxxxxxx>
References: <20050305141225.GA5180@xxxxxxxxxxxxxxxxx> <20050307100744.429e100a@xxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.7.5) Gecko/20050106 Debian/1.7.5-1
Stephen Hemminger wrote:

This small patch does this. Currently vlan_TCI-priority directly
mapped to skb->priority, but this looks enough.

I don't see why the VLAN code doesn't handle this itself. I don't like special
case layer violations because it becomes a slippery slope with more and
more additions.

The patch is meant for bridges briging vlan frames without doing
vlan themselves. I agree with you, from the bridge point of view
a vlan header is just as outside of its scope as an IP header,
that's why I proposed to put it in an ebtables target and make
it useable for vlan and IP.

Regards
Patrick

<Prev in Thread] Current Thread [Next in Thread>