Thank you very much (domo arigato gozaimasu) for your feedback. Please
see below for my comments.
On 7 Mar 2005 at 7:38, B wrote:
> In article <20050307.073213.32943613.yoshfuji@xxxxxxxxxxxxxx> (at Mon, 07 Mar
> 2005 07:32:13 +0900 (JST)), YOSHIFUJI Hideaki / $B5HF#1QL@ (B
> <yoshfuji@xxxxxxxxxxxxxx> says:
> > In article <20050306222118.401D11ED3D@xxxxxxxxxxxxxxxxxxx> (at Sun, 06 Mar
> > 2005 23:21:17 +0100), domen@xxxxxxxxxxxx says:
> > >
> > > compile warning cleanup - handle copy_to/from_user error
> > > returns
> > Wrong. You introduce a leak.
> Ah, sorry, not really,
Actually, you are correct. This is one of my first attempts at a patch
submittal and this is one of a few patches where I did not check for side
effects. I will try very much not to make that same mistake again.
> but I still think it is wrong:
> fl_intern() insert it to hash, and
> then you freed up the memory.
> I believe this is wrong.
Yes, you are completely correct, and thank you for catching this.
I will submit a more correct patch shortly.