| To: | domen@xxxxxxxxxxxx |
|---|---|
| Subject: | Re: [patch 4/5] net/ipv6/ip6_flowlabel.c: copy_to_user return code |
| From: | YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx> |
| Date: | Mon, 07 Mar 2005 07:38:43 +0900 (JST) |
| Cc: | davem@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx, yrgrknmxpzlk@xxxxxxxxx, yoshfuji@xxxxxxxxxxxxxx |
| In-reply-to: | <20050307.073213.32943613.yoshfuji@xxxxxxxxxxxxxx> |
| Organization: | USAGI Project |
| References: | <20050306222118.401D11ED3D@xxxxxxxxxxxxxxxxxxx> <20050307.073213.32943613.yoshfuji@xxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
In article <20050307.073213.32943613.yoshfuji@xxxxxxxxxxxxxx> (at Mon, 07 Mar 2005 07:32:13 +0900 (JST)), YOSHIFUJI Hideaki / 吉藤英明 <yoshfuji@xxxxxxxxxxxxxx> says: > In article <20050306222118.401D11ED3D@xxxxxxxxxxxxxxxxxxx> (at Sun, 06 Mar > 2005 23:21:17 +0100), domen@xxxxxxxxxxxx says: > > > > > compile warning cleanup - handle copy_to/from_user error > > returns > > Wrong. You introduce a leak. Ah, sorry, not really, but I still think it is wrong: fl_intern() insert it to hash, and then you freed up the memory. I believe this is wrong. --yoshfuji |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [patch 4/5] net/ipv6/ip6_flowlabel.c: copy_to_user return code, YOSHIFUJI Hideaki / 吉藤英明 |
|---|---|
| Next by Date: | [BK PATCHES] 2.6.x net driver updates, Jeff Garzik |
| Previous by Thread: | Re: [patch 4/5] net/ipv6/ip6_flowlabel.c: copy_to_user return code, YOSHIFUJI Hideaki / 吉藤英明 |
| Next by Thread: | Re: [patch 4/5] net/ipv6/ip6_flowlabel.c: copy_to_user return code, Stephen Biggs |
| Indexes: | [Date] [Thread] [Top] [All Lists] |