Re: [PATCH 1/1] More ethtool support for sis900 (with locking)

[Francois Romieu <romieu@xxxxxxxxxxxxx>]

Daniele Venzano <webvenza@xxxxxxxxx> :
[...]
> Index: sis900.c
> ===================================================================
> --- a/drivers/net/sis900.c    (revision 95)
> +++ b/drivers/net/sis900.c    (revision 98)
[...]
> @@ -1943,10 +1952,47 @@
>       sis_priv->msg_enable = value;
>  }
>  
> +static u32 sis900_get_link(struct net_device *net_dev)
> +{
> +     struct sis900_private *sis_priv = net_dev->priv;

Any reason to not use netdev_priv() ?

I would not mind an empty line between the declaration of variables
and the actual code.

--
Ueimor