On 05/mar/05, at 19:28, Jeff Garzik wrote:
+static int sis900_set_settings(struct net_device *net_dev,
+ struct ethtool_cmd *cmd)
+{
+ struct sis900_private *sis_priv = net_dev->priv;
+ return mii_ethtool_sset(&sis_priv->mii_info, cmd);
+}
+
+static int sis900_nway_reset(struct net_device *net_dev)
+{
+ struct sis900_private *sis_priv = net_dev->priv;
+ return mii_nway_restart(&sis_priv->mii_info);
+}
I should think you want locking for these, as is present in other
drivers...
I saw the locking, but I couldn't come up with a reason for it. Is it
needed because of kernel wide preemption ?
I don't like copying blindly and the documentation for the mii
interface is a bit lacking...
Will follow up with a new patch in a few minutes...
--
Daniele Venzano
http://www.brownhat.org
|