| To: | Thomas Graf <tgraf@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] [NET]: Fix deletion of local addresses only varying in prefix length |
| From: | Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> |
| Date: | Sun, 6 Mar 2005 05:30:09 +1100 |
| Cc: | davem@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <20050305162323.GM31837@xxxxxxxxxxxxxx> |
| References: | <20050304012003.GA31837@xxxxxxxxxxxxxx> <E1D78DN-0002te-00@xxxxxxxxxxxxxxxxxxxxxxxx> <20050304131419.GE31837@xxxxxxxxxxxxxx> <20050304233212.GA27421@xxxxxxxxxxxxxxxxxxx> <20050305002910.GJ31837@xxxxxxxxxxxxxx> <20050305005911.GA27804@xxxxxxxxxxxxxxxxxxx> <20050305162323.GM31837@xxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.6+20040907i |
On Sat, Mar 05, 2005 at 05:23:23PM +0100, Thomas Graf wrote: > > Although we should keep the behaviour of ip a a 1.1.1.1/24; ip a d > 1.1.1.1, what about ip a a 1.1.1.1/24; ip a d 1.1.1.1/16? I think the > latter should not result in a deletion. We could achieve this by checking > the prefix length if either the exact-match flag is set or the > prefixlength is != 32. This is of course quite minor and only affects > old iproute2 versions in combination with newer kernels. It's fine by me as long as the code doesn't get too complex because of it. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt |
| Previous by Date: | Re: Still bug-hunting, David S. Miller |
|---|---|
| Next by Date: | Re: Do you know the linux TCP stack?, Andi Kleen |
| Previous by Thread: | Re: [PATCH] [NET]: Fix deletion of local addresses only varying in prefix length, Thomas Graf |
| Next by Thread: | [PATCH] [NET]: Fix deletion of equal local IPv4 addresses only varying in prefix length, Thomas Graf |
| Indexes: | [Date] [Thread] [Top] [All Lists] |